-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update globe and add hemispheres to be more inclusive #35
Conversation
Hmmm. Although they work really great at bigger sizes, I find that it's hard to figure out what it is at smaller sizes. Except maybe for globe-w. I really wonder if we should try to simplify them to the max. Removing as much detail as possible. And keep only 2 or 3 large shapes that indicate which side on the globe we are on. Probably, the result won't be geographically correct, but that's not a problem. Just, when I look at these. I think Africa should be more detached from Asia and Europe to display well. Antartica, though lovely to have there, is maybe not giving much clue. What do you think? |
This PR changes files in the directory which I deleted. I hope there didn't go any other commits into the fork-awesome directory. Please note that this directory was always a dead end. (One of the reasons why I deleted it.) Maybe we should have a guide book, where & how to add or change icons: afaik the procedure is as follows:
|
I just saw that 1426943 also changed files in the fork-awesome directory. Was this change ever propagated to the real less/scss/css files? (I couldn't find anything in the logs.) |
@tessus For sure in a later built. If not Medium and Medium-square would not show up in the doc. And they do: https://forkawesome.github.io/Fork-Awesome/icon/medium/ |
Yes. Way better. Totally works at small sizes. |
I am trying to update this but I have no idea how to fix this branch and get it so I can update it. I'm not familiar enough with git. |
You created a branch You have to checkout that branch: If you do not have it locally, pull all the latest changes or clone this repo. Then checkout the globes branch. However, please note that the directory If you need additional help with git, please let me know. You can also send me an email, if that's more convenient. |
It looks like you haven't applied the changes that were originally in the fork-awesome directory to the correct files. After the second commit only a few files remain, but they conflict with the current ones in master. Unfortunately I do not know how to add icons otherwise I'd help you to start applying the changes to current master. |
I think we should close this in favor of #67 |
Yes, makes sense. Thank you for the new PR. |
Add Eastern and Western hemisphere icons and make the default globe icon more central.