Disallow use of fetch=SUBSELECT on to-one associations.

GEWIS · Oct 10, 2023 · ff28ba8 · ff28ba8
1 parent 41410e6
commit ff28ba8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php b/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
@@ -1831,6 +1831,10 @@ protected function _validateAndCompleteAssociationMapping(array $mapping)
             $mapping['fetch'] = self::FETCH_LAZY;
         }
 
+        if ($mapping['fetch'] === self::FETCH_SUBSELECT && $mapping['type'] & self::TO_ONE) {
+            throw MappingException::illegalFetchSubselectAssociation($this->name, $mapping['fieldName']);
+        }
+
         // Cascades
         $cascades = isset($mapping['cascade']) ? array_map('strtolower', $mapping['cascade']) : [];
 

diff --git a/lib/Doctrine/ORM/Mapping/MappingException.php b/lib/Doctrine/ORM/Mapping/MappingException.php
@@ -742,6 +742,15 @@ public static function illegalToManyIdentifierAssociation($className, $field)
         ));
     }
 
+    public static function illegalFetchSubselectAssociation(string $className, string $field): MappingException
+    {
+        return new self(sprintf(
+            'Cannot use fetch-mode SUBSELECT for a to-one association on entity "%s#%s".',
+            $className,
+            $field
+        ));
+    }
+
     /**
      * @param string $className
      *

diff --git a/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php b/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataTest.php
@@ -1353,6 +1353,20 @@ public function testRejectsEmbeddableWithoutValidClassName(): void
             'columnPrefix' => false,
         ]);
     }
+
+    public function testIllegalFetchModeSubselect(): void
+    {
+        $metadata = new ClassMetadata(TestEntity1::class);
+
+        $this->expectException(MappingException::class);
+        $this->expectExceptionMessage('Cannot use fetch-mode SUBSELECT for a to-one association on entity');
+
+        $metadata->mapManyToOne([
+            'fieldName'    => 'association',
+            'targetEntity' => DDC2700MappedSuperClass::class,
+            'fetch'        => ClassMetadata::FETCH_SUBSELECT,
+        ]);
+    }
 }
 
 /** @MappedSuperclass */