Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection-security constraint (issue #961) #1021

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Dec 20, 2024

Committer Notes

This constraint defines the list of allowed values for the connection-security property.

Related issue: #961.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner December 20, 2024 21:47
@DimitriZhurkin DimitriZhurkin self-assigned this Dec 20, 2024
Comment on lines +110 to +112
<allowed-values id="connection-security" target="system-implementation/component/prop[@name='connection-security' and @ns='https://fedramp.gov/ns/oscal']/@value" allow-other="yes" level="WARNING">
<formal-name>Connection Security</formal-name>
<description>Identifies connection security value.</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the help url?

Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good stuff! Just a couple small things that caught my attention.

@@ -107,6 +107,24 @@
<enum value="network">A physical or virtual network.</enum>
</allowed-values>

<allowed-values id="connection-security" target="system-implementation/component/prop[@name='connection-security' and @ns='https://fedramp.gov/ns/oscal']/@value" allow-other="yes" level="WARNING">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to http since we finally moved away from the https namespace.

Suggested change
<allowed-values id="connection-security" target="system-implementation/component/prop[@name='connection-security' and @ns='https://fedramp.gov/ns/oscal']/@value" allow-other="yes" level="WARNING">
<allowed-values id="connection-security" target="system-implementation/component/prop[@name='connection-security' and @ns='http://fedramp.gov/ns/oscal']/@value" allow-other="yes" level="WARNING">

@Gabeblis Gabeblis linked an issue Dec 30, 2024 that may be closed by this pull request
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection Security Allowed Values
3 participants