Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-vendor-name constraint #1037

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Dec 26, 2024

Committer Notes

Purpose

This PR aims to add the inventory-item-has-vendor-name constraint which ensures that every inventory item has a "vendor-name" FedRAMP extension prop, either on the inventory-item itself or within the component linked to the inventory-item.

Changes

Added constraint:

  • inventory-item-has-vendor-name

Added valid/invalid test content:

  • ssp-inventory-item-has-vendor-name-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 26, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 26, 2024 13:36
kyhu65867
kyhu65867 previously approved these changes Dec 26, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-1034 branch from 81b6def to e5e7566 Compare December 26, 2024 13:50
@Gabeblis Gabeblis requested review from kyhu65867 and a team December 26, 2024 13:51
@Gabeblis Gabeblis changed the title Add inventory-item-has-vendor-name constraint [DO NOT MERGE] Add inventory-item-has-vendor-name constraint Dec 26, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-1034 branch from e5e7566 to 228b331 Compare December 26, 2024 16:19
@Gabeblis Gabeblis linked an issue Dec 26, 2024 that may be closed by this pull request
15 tasks
@Gabeblis Gabeblis changed the title [DO NOT MERGE] Add inventory-item-has-vendor-name constraint Add inventory-item-has-vendor-name constraint Dec 27, 2024
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good!! Unrelated to changes made in this PR, there are some invalide component UUID references in the example SSP inventory, however, those can be fixed separately (I created #1049 to address that).

@wandmagic wandmagic merged commit fa461b0 into GSA:develop Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - Vendor Name
4 participants