Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-software-version constraint #1039

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Dec 26, 2024

Committer Notes

Purpose

This PR aims to add the inventory-item-has-software-version constraint which ensures that every inventory items has a "os-version" or "software-version"

Changes

Added constraint:

  • inventory-item-has-software-version

Added valid/invalid test content:

  • ssp-inventory-item-has-software-version-INVALID.xml
  • Edited fedramp-ssp-example.oscal.xml to align with constraint

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 26, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 26, 2024 13:45
kyhu65867
kyhu65867 previously approved these changes Dec 26, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 1ef66a0 to fdd39f0 Compare December 26, 2024 13:49
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from fdd39f0 to dc20b52 Compare December 26, 2024 13:49
@Gabeblis Gabeblis requested review from kyhu65867 and a team December 26, 2024 13:52
@Gabeblis Gabeblis changed the title Add inventory-item-has-software-version constraint [DO NOT MERGE] Add inventory-item-has-software-version constraint Dec 26, 2024
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch 2 times, most recently from 30f246a to 00217c2 Compare December 26, 2024 18:06
@Gabeblis Gabeblis linked an issue Dec 26, 2024 that may be closed by this pull request
15 tasks
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 00217c2 to c47b8b6 Compare December 27, 2024 15:10
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from e7bd987 to 51e8e19 Compare December 27, 2024 22:34
@Gabeblis Gabeblis changed the title [DO NOT MERGE] Add inventory-item-has-software-version constraint Add inventory-item-has-software-version constraint Dec 29, 2024
@Gabeblis
Copy link
Contributor Author

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-version' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

@wandmagic
Copy link
Collaborator

needs a rebase, but looks good to me

@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 51e8e19 to 485f64b Compare December 30, 2024 15:33
Rene2mt
Rene2mt previously approved these changes Dec 30, 2024
wandmagic
wandmagic previously approved these changes Dec 30, 2024
@Gabeblis Gabeblis dismissed stale reviews from wandmagic and Rene2mt via 0419936 December 30, 2024 19:13
@Gabeblis Gabeblis force-pushed the constraints/issue-1036 branch from 485f64b to 0419936 Compare December 30, 2024 19:13
@Rene2mt
Copy link
Member

Rene2mt commented Dec 31, 2024

@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-version' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it.

@Gabeblis this is similar to 1038 where the prop we need isnot supported by upstream OSCAL. We're discussing several options - see #1038 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inventory - OS or Software Version
5 participants