-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inventory-item-has-software-version
constraint
#1039
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
1ef66a0
to
fdd39f0
Compare
fdd39f0
to
dc20b52
Compare
inventory-item-has-software-version
constraintinventory-item-has-software-version
constraint
30f246a
to
00217c2
Compare
00217c2
to
c47b8b6
Compare
e7bd987
to
51e8e19
Compare
inventory-item-has-software-version
constraintinventory-item-has-software-version
constraint
@Rene2mt As of right now, upstream allowed-values don't allow for a 'software-version' prop in a component. Tests fail when I try to add the example of an inventory-item not having the prop, but the linked component does have it. |
needs a rebase, but looks good to me |
51e8e19
to
485f64b
Compare
485f64b
to
0419936
Compare
@Gabeblis this is similar to 1038 where the prop we need isnot supported by upstream OSCAL. We're discussing several options - see #1038 (comment) |
Committer Notes
Purpose
This PR aims to add the
inventory-item-has-software-version
constraint which ensures that every inventory items has a "os-version" or "software-version"Changes
Added constraint:
inventory-item-has-software-version
Added valid/invalid test content:
ssp-inventory-item-has-software-version-INVALID.xml
fedramp-ssp-example.oscal.xml
to align with constraintAdded yaml files for testing:
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.