Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows IECoreArnoldTest #5110

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Windows IECoreArnoldTest #5110

wants to merge 4 commits into from

Conversation

ericmehl
Copy link
Collaborator

This gets IECoreArnoldTest passing on Windows.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ericmehl
UniverseBlockTest : Adapt for Windows
b672588 
- Use "gaffer.cmd". We don't use `str( Gaffer.executablePath() )` to
avoid the dependency on the `Gaffer` module.
- Arnold returns `atStringStruct` instead of `atStringReturn`.
- Don't attempt to run `kick` which isn't working on Windows currently.
@ericmehl
OutputDriverTest : Skip tests on Windows.
44911f9 
`kick` on Windows is not currently working. I've gone ahead and changed
the path syntax so that when it does work there will be one less change
to make.
@ericmehl
RendererTest : Adapt for Windows
66e6e9b 
- OSL search paths use posix-style formatting
- Windows cannot reliably make directories read-only, so we skip that
portion of the test.
- Something is holding on to the Arnold log file even after destroying
the renderer. This prevents Windows from cleaning up without errors.
Skip it as likely to be an Arnold issue.
@ericmehl ericmehl changed the title Windows ie core arnold test Windows IECoreArnoldTest Jan 27, 2023
@johnhaddon johnhaddon mentioned this pull request Jan 30, 2023
Closed
@ericmehl ericmehl mentioned this pull request Feb 10, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericmehl