Metadata : Add targetsWithMetadata() function
#6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is equivalent to `nodesWithMetadata()` and `plugsWithMetadata()`, but for string targets. Ths also switched the internal container to maintain order of insertion so that we can return targets in the order they were first created.
johnhaddon
force-pushed
the
metadataPR
branch
from
ba78f64 to
23d3118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a few PRs containing some of the groundwork for GafferRenderMan. The final GafferRenderMan PR is likely to be a bit big, so I'm breaking off what I can to be reviewed separately.
The
targetsWithMetadata()function will be used in GafferRenderMan to automatically populate RenderManAttributes and RenderManOptions nodes from metadata-based definitions - the same definitions used to populate the AttributeEditor and RenderPassEditor. We're planning to eventually make the metadata be the single-source-of-truth for all renderers, but RenderMan will be the first one.