Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValuePlug : Disconnection no longer emits plugSet signal #6223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ValuePlug : Disconnection no longer emits plugSet signal #6223

wants to merge 2 commits into from

Conversation

ivanimanishi
Copy link
Member

Emitting plugSet signal at that stage was causing issues because the
signal was being triggered before the input was changed, which could
result in incorrect computation during those calls.

Besides, plugSet signal is meant to mean "setValue() has been called",
and not "getValue() will return something different now" (which is what
plugDirtied signal is meant to represent).

Breaking changes

  • ValuePlug : Disconnection no longer emits plugSet signal.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ivanimanishi
ValuePlug : Disconnection no longer emits plugSet signal
eaa4132 
Emitting plugSet signal at that stage was causing issues because the
signal was being triggered before the input was changed, which could
result in incorrect computation during those calls.

Besides, `plugSet` signal is meant to mean "setValue() has been called",
and not "getValue() will return something different now" (which is what
`plugDirtied` signal is meant to represent).
@ivanimanishi
DependencyNodeTest : Avoid use of reserved word as a variable
51f37c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhaddon johnhaddon Awaiting requested review from johnhaddon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivanimanishi