Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence icacls commands #6243

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Silence icacls commands #6243

merged 1 commit into from
Jan 30, 2025
+15 −3

Conversation

ericmehl
Copy link
Collaborator

icacls was introduced in #6204 to change permissions for some Windows tests. It insists on outputting the success of the command which clutters the test results, even with the /q switch. Instead, we pipe the results of those subprocesses to /dev/null.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@ericmehl
Tests (Windows) : Silence icacls calls.
eab4473 
It seems the the `/q` flag for `icacls` only suppresses the success
message for some commands. Instead we pipe to `/dev/null` to declutter
the test results.
@johnhaddon johnhaddon merged commit 33ec3cc into GafferHQ:1.5_maintenance Jan 30, 2025
5 checks passed
@ericmehl ericmehl deleted the silencePermissions branch January 30, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericmehl @johnhaddon