Added some documentation on coroutines #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jameysharp you're welcome. What you've told me should help me fix things up a bit further. The commit message is indeed a mess - I rebased over a large range of commits, so I'll try to clean that up. I'm a little new to GitHub pull request workflow - should I squash again and do a force push? |
|
A pull request is pretty unusual as git workflows go. It's the only case I can think of where a force push is a good idea. So yes, you can either squash again or |
This is a combination of my own notes when trying to understand the coroutine implementation, and an integration of the corrections and better explanations that jameysharp provided.
|
Okay, I think I've integrated in everything that you noted (I'm checking your notes again now), and hopefully understood the details properly this time. |
jameysharp
added a commit
that referenced
this pull request
Jul 28, 2015
Add documentation on coroutines: thanks, @Hodapp87!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to understand the coroutine code in order to make some additions to it, and in the process had added some of my own documentation. I think it's all correct, but it's my own guesswork.