Skip to content

Commit

Permalink
Remove deprecated Aggregator/AggregatorFactory methods (apache#3894)
Browse files Browse the repository at this point in the history
  • Loading branch information
jon-wei authored and fjy committed Feb 1, 2017
1 parent 151ff6d commit e6b95e8
Show file tree
Hide file tree
Showing 37 changed files with 0 additions and 211 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ public float getFloat()
return (float) mutableBitmap.size();
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ public float getFloat()
return (float) 0;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ public float getFloat()
return (float) most;
}

@Override
public String getName()
{
return name;
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,6 @@ public int getMaxIntermediateSize()
return Longs.BYTES;
}

@Override
public Object getAggregatorStartValue()
{
return initValue;
}

@Override
public boolean equals(Object o)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ public void testAggregator()
{
TimestampAggregator aggregator = (TimestampAggregator) aggregatorFactory.factorize(selectorFactory);

Assert.assertEquals(aggType, aggregator.getName());

for (Timestamp value: values) {
aggregate(selector, aggregator);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,6 @@ public long getLong()
throw new UnsupportedOperationException("Not implemented");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ public long getLong()
throw new UnsupportedOperationException("Not implemented");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ public long getLong()
throw new UnsupportedOperationException("ApproximateHistogramAggregator does not support getLong()");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,6 @@ public long getLong()
throw new UnsupportedOperationException("ApproximateHistogramFoldingAggregator does not support getLong()");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ public Object get()
return holder;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@ public interface Aggregator {
Object get();
float getFloat();

/**
* Deprecated, to be removed in 0.10.0. See https://github.com/druid-io/druid/issues/3588.
*/
@Deprecated String getName();
void close();

long getLong();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,6 @@ public AggregatorFactory getMergingFactory(AggregatorFactory other) throws Aggre
*/
public abstract int getMaxIntermediateSize();

/**
* Deprecated, to be removed in 0.10.0. See https://github.com/druid-io/druid/issues/3588.
*/
@Deprecated
public Object getAggregatorStartValue()
{
throw new UnsupportedOperationException("getAggregatorStartValue is deprecated");
}

/**
* Merges the list of AggregatorFactory[] (presumable from metadata of some segments being merged) and
* returns merged AggregatorFactory[] (for the metadata for merged segment).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,6 @@ public float getFloat()
return 0;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ public long getLong()
return count;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public long getLong()
return (long) max;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public long getLong()
return (long) min;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@ public long getLong()
return (long) sum;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ public long getLong()
return delegate.getLong();
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ public long getLong()
throw new UnsupportedOperationException("HistogramAggregator does not support getLong()");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,6 @@ public long getLong()
return (long) current;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public long getLong()
return max;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public long getLong()
return min;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@ public long getLong()
return sum;
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@ public long getLong()
throw new UnsupportedOperationException("CardinalityAggregator does not support getLong()");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ public float getFloat()
return (float) firstValue;
}

@Override
public String getName()
{
return name;
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,12 +225,6 @@ public int getMaxIntermediateSize()
return Longs.BYTES + Doubles.BYTES;
}

@Override
public Object getAggregatorStartValue()
{
throw new UnsupportedOperationException();
}

@Override
public boolean equals(Object o)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ public float getFloat()
return (float) firstValue;
}

@Override
public String getName()
{
return name;
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,6 @@ public int getMaxIntermediateSize()
return Longs.BYTES * 2;
}

@Override
public Object getAggregatorStartValue()
{
throw new UnsupportedOperationException();
}

@Override
public boolean equals(Object o)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,6 @@ public long getLong()
throw new UnsupportedOperationException("HyperUniquesAggregator does not support getLong()");
}

@Override
public String getName()
{
throw new UnsupportedOperationException("getName is deprecated");
}

@Override
public Aggregator clone()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ public float getFloat()
return (float) lastValue;
}

@Override
public String getName()
{
return name;
}

@Override
public void close()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,6 @@ public int getMaxIntermediateSize()
return Longs.BYTES + Doubles.BYTES;
}

@Override
public Object getAggregatorStartValue()
{
throw new UnsupportedOperationException();
}

@Override
public boolean equals(Object o)
{
Expand Down
Loading

0 comments on commit e6b95e8

Please sign in to comment.