Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jmhbh committed Nov 15, 2024
1 parent 9fb4429 commit e40341e
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 8 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -680,14 +680,18 @@ message ExtAuthConfig {
}

}
// This API is only supported for Gloo Gateway Portal.
message PortalAuthConfig {
// The portal web server url used to validate credentials generated by the portal for the backing service(s).
string url = 1;
// The api key header name used to find the api key in the request headers.
// If provided will not authorize requests without the api key in the request headers.
// If not provided, will authorize requests with a Bearer token but must be chained with an AccessTokenValidation AuthConfig which will validate the token.

string api_key_header = 2;
// Options to connect to redis. If not provided, data will be cached in memory.
RedisOptions redis_options = 3;
// The frequency at which the validated credential data should be refreshed by quering the portal web server.
// The frequency at which the validated credential data should be refreshed by quering the portal web server. Defaults to 60s
google.protobuf.Duration cache_duration = 4;
// Timeout for the portal web server to respond. Defaults to 200ms
google.protobuf.Duration request_timeout = 5;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1616,10 +1616,13 @@ message PassThroughHttp {
}

// PortalAuth is used to authorize requests for credentials generated by the portal web server.
// This API is only supported for Gloo Gateway Portal.
message PortalAuth {
// The portal web server url used to validate credentials generated by the portal for the backing service(s).
string url = 1;
// The api key header name used to find the api key in the request headers.
// If provided will not authorize requests without the api key in the request headers.
// If not provided, will authorize requests with a Bearer token but must be chained with an AccessTokenValidation AuthConfig which will validate the token.
string api_key_header = 2;
// Options to connect to redis. If not provided, data will be cached in memory.
RedisOptions redis_options = 3;
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e40341e

Please sign in to comment.