Skip to content

Commit

Permalink
increase the remote write bucket range (prometheus#7323)
Browse files Browse the repository at this point in the history
* increase the remote write bucket range

Increase the range of remote write buckets to capture times above 10s for laggy scenarios
Buckets had been: {.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10}
Buckets are now: {0.03125, 0.0625, 0.125, 0.25, 0.5, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512}

Signed-off-by: Bert Hartmann <[email protected]>

* revert back to DefBuckets with addons to be backwards compatible

Signed-off-by: Bert Hartmann <[email protected]>

* shuffle the buckets to maintain 2-2.5x increases

Signed-off-by: Bert Hartmann <[email protected]>
  • Loading branch information
BertHartm authored Jun 4, 2020
1 parent f9d21f1 commit 82c7cd3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion storage/remote/queue_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func newQueueManagerMetrics(r prometheus.Registerer, rn, e string) *queueManager
Subsystem: subsystem,
Name: "sent_batch_duration_seconds",
Help: "Duration of sample batch send calls to the remote storage.",
Buckets: prometheus.DefBuckets,
Buckets: append(prometheus.DefBuckets, 25, 60, 120, 300),
ConstLabels: constLabels,
})
m.highestSentTimestamp = &maxGauge{
Expand Down

0 comments on commit 82c7cd3

Please sign in to comment.