Skip to content

Persist visitor params values in public visitor session cookie #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

Persist visitor params values in public visitor session cookie #3231

merged 6 commits into from
May 14, 2025

Conversation

spastorelli
Copy link
Contributor

@spastorelli spastorelli commented May 13, 2025 •
edited
Loading

This PR aims to persist visitor params values in public visitor session cookie.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f41c502

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

spastorelli
spastorelli commented May 13, 2025
View reviewed changes
spastorelli
spastorelli commented May 13, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited
Loading

Summary of the deployments:

Version 1

Version URL Status
Latest commit https://eb268e8e.gitbook-open.pages.dev ✅
PR https://pr3231.gitbook-open.pages.dev ✅

Version 2

Version URL Status
Vercel https://gitbook-v2-qu7leu3nk-gitbook.vercel.app ✅
Cloudflare https://62ba3187-gitbook-open-v2-preview.gitbook.workers.dev ✅

Test content

Site v1 2v 2c
GitBook https://eb268e8e.gitbook-open.pages.dev/docs.gitbook.com https://gitbook-v2-qu7leu3nk-gitbook.vercel.app/url/docs.gitbook.com https://62ba3187-gitbook-open-v2-preview.gitbook.workers.dev/url/docs.gitbook.com
E2E https://eb268e8e.gitbook-open.pages.dev/gitbook.gitbook.io/test-gitbook-open https://gitbook-v2-qu7leu3nk-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open https://62ba3187-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci Argos CI
Copy link

argos-ci bot commented May 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - May 14, 2025, 7:21 AM
customers-v2 (Inspect) ✅ No changes detected - May 14, 2025, 7:25 AM
default (Inspect) ✅ No changes detected - May 14, 2025, 7:24 AM
v2-cloudflare (Inspect) ✅ No changes detected - May 14, 2025, 7:25 AM
v2-vercel (Inspect) 👍 Changes approved 4 changed May 14, 2025, 7:25 AM

taranvohra
taranvohra reviewed May 13, 2025
View reviewed changes
@spastorelli spastorelli requested a review from taranvohra May 13, 2025 16:02
taranvohra
taranvohra approved these changes May 14, 2025
View reviewed changes
@spastorelli spastorelli merged commit cc37e2a into main May 14, 2025
21 checks passed
@spastorelli spastorelli deleted the steeve/persist-visitor-params-in-session-cookie branch May 14, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taranvohra taranvohra taranvohra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spastorelli @taranvohra