Skip to content

Calculate class more explicitly & separately to fix horizontal table cell alignment issue #3252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

viktorrenkema
Copy link
Contributor

@viktorrenkema viktorrenkema commented May 21, 2025

In this PR I fixed an issue with horizontal alignment not propagating to children of table text cells. It fixed the original case, but customer mentioned another situation still showed the problem.

I don't think the fix is wrong, the prior PR should also correctly target the new case the user mentioned. Instead I think the problem is tailwind being flaky, it's known that inline calculation of classes can cause the classes not to show up in the compiled css. This pr's change made the css apply locally, I'll test once it actually goes through to make sure it's the same case in prod.

~ should close https://linear.app/gitbook-x/issue/RND-6658/annotations-in-table-cells-with-multi-line-text-makes-it-center

before:

CleanShot 2025-05-21 at 13 35 26@2x

after:

CleanShot 2025-05-21 at 13 35 48@2x

Copy link

linear bot commented May 21, 2025

Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: 44761f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented May 21, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - May 21, 2025, 11:40 AM
customers-v2 (Inspect) 👍 Changes approved 79 changed May 21, 2025, 11:40 AM
default (Inspect) ✅ No changes detected - May 21, 2025, 11:41 AM
v2-cloudflare (Inspect) ✅ No changes detected - May 21, 2025, 11:43 AM
v2-vercel (Inspect) ✅ No changes detected - May 21, 2025, 11:57 AM

@viktorrenkema viktorrenkema merged commit fae34e5 into main May 21, 2025
21 checks passed
@viktorrenkema viktorrenkema deleted the viktor/rnd-6658-annotations-in-table-cells-with-multi-line-text-makes-it branch May 21, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants