fix(gix): extend lifetime of iterators #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the iterators would return references with lifetimes that were shorter than the actual lifetimes of the `gix::Reference` themselves. This was dues to a footgun with `'_` (eliding the lifetime). When a function returns an elided lifetime, this lifetime usually is the lifetime of the `&self` parameter, but sometimes it is the lifetime of the type itself (e.g. `Iter<'_>`). I made the lifetimes explicit to ensure we were using the correct ones. Closes GitoxideLabs#2103
Byron
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the iterators would return references with lifetimes that were shorter than the actual lifetimes of the
gix::Referencethemselves. This was dues to a footgun with'_(eliding the lifetime).When a function returns an elided lifetime, this lifetime usually is the lifetime of the
&selfparameter, but sometimes it is the lifetime of the type itself (e.g.Iter<'_>).I made the lifetimes explicit to ensure we were using the correct ones.
Closes #2103