-
-
Notifications
You must be signed in to change notification settings - Fork 376
Report August 2025 #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report August 2025 #2130
Conversation
@EliahKagan As a heads-up, it seems CI is broken now because Git changed and probably packs references more often or more aggressively. There seems to be at least one script that assumes the presence of a loose reference that is now packed. |
The new CI failures all strongly appear to be due to the change in git/git@a5a727c. The I'm working on this now, and I expect to be able to fix it by using If for some reason that doesn't work, I believe the previous version is still available from the git-core PPA so we may be able to downgrade to it on CI as a temporary measure. If for some reason we can't do that, we can downgrade even further as a temporary measure by using |
Starting in Git 2.51.0, at least one of the `git remote` commands in the `make_remote_config_repos.sh` fixutre script fails, which causes a subsequently run command depending on it to fail. This is the cause of the CI failures observed in GitoxideLabs#2130. But when any command fails, the intention is that the script fails fast. To help achieve this, `set -e` is used. But the rules for `set -e` have a number of exceptions. At least in some versions of `bash`, the way `&&` was being used kept it from failing fast. This changes that to run the commands separately, surfacing the specific `git remote` command that fails, rather than a subsequent command that fails later as a result of the first failure.
Instead of `git remote`. Since Git 2.51.0, path collisions in remote names are automatically detected and rejected when `git remote add` is used to attempt to add them, since creating such collisions is usually unintentional: git/git@a5a727c However, we deliberately do this in our test suite, in the `make_remote_config_repos.sh` fixture script. When Git 2.51.0 came to be used on CI, some new test failures arose as a result, as observed in GitoxideLabs#2130. This fixes the script by using two `git config` commands rather than a `git remote` command to produce the overlap. This technique is (intentionally) still allowed in Git 2.51.0.
The new CI failures are fixed since #2132. |
Tasks