HPCC-16438 Fix minor resource leak in configmgr reported by coverity

HPCC-16438 Fix minor resource leak in configmgr reported by coverity - Delete possibly previously NEW'ed var before reassignment to avoid override - Per code review comments, no need to check if NULL before delete - Per code review comments, use delete directive rather than function - Add comment explaining the unusual delete for ease of maintenance Signed-off-by: Rodrigo Pastrana <[email protected]>
Global-localhost · Mar 3, 2017 · f9ea54f · f9ea54f
1 parent 31066f6
commit f9ea54f
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/deployment/deployutils/wizardInputs.cpp b/deployment/deployutils/wizardInputs.cpp
@@ -316,6 +316,7 @@ CInstDetails* CWizardInputs::getServerIPMap(const char* compName, const char* bu
 
       if(m_compIpMap.find(buildSetName) != NULL)
       {
+        delete instDetails; // Possibly previously NEW'ed, delete to avoid override
         instDetails = m_compIpMap.getValue(buildSetName);
 
         if( (instDetails->getIpAssigned()).ordinality() != numOfNodes)