fix: Login Modal showing everytime on Media Page

Refactor conditional statements in AddToFavourites, AddToNotification, and MediaActionOptionsButton components; remove unused import in MediaActionOptionsButton; add mediaInfo prop to MediaCard.MediaImgLink in MangaNavListHover
GodxD69 · Jul 12, 2024 · f44cc83 · f44cc83
1 parent b719f32
commit f44cc83
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/app/components/Buttons/AddToFavourites/index.tsx b/app/components/Buttons/AddToFavourites/index.tsx
@@ -34,10 +34,12 @@ export function Button({ mediaInfo, children, svgOnlyColor, isActiveOnAnilist, c
 
     useEffect(() => {
 
-        if ((!user && !anilistUser) || loading) return
+        if (!loading) {
 
-        dispatch(toggleShowLoginModalValue())
-        isMediaOnUserDoc()
+            if (!user && !anilistUser) dispatch(toggleShowLoginModalValue())
+            if (!user && !anilistUser) isMediaOnUserDoc()
+
+        }
 
     }, [user, anilistUser, loading])
 

diff --git a/app/components/Buttons/AddToNotification/index.tsx b/app/components/Buttons/AddToNotification/index.tsx
@@ -36,10 +36,12 @@ function AddToNotificationsButton({ mediaInfo }: { mediaInfo: ApiDefaultResult |
 
     useEffect(() => {
 
-        if ((!user && !anilistUser) || loading) return
+        if (!loading) {
 
-        dispatch(toggleShowLoginModalValue())
-        isUserAssignedToThisMediaNotications()
+            if (!user && !anilistUser) dispatch(toggleShowLoginModalValue())
+            if (!user && !anilistUser) isUserAssignedToThisMediaNotications()
+
+        }
 
     }, [user, anilistUser, loading])
 

diff --git a/app/components/MediaCards/MediaCard/MediaActionOptionsButton/index.tsx b/app/components/MediaCards/MediaCard/MediaActionOptionsButton/index.tsx
@@ -5,7 +5,7 @@ import { AnimatePresence, motion } from 'framer-motion'
 import PlusSvg from "@/public/assets/plus-lg.svg"
 import { ApiDefaultResult } from '@/app/ts/interfaces/apiAnilistDataInterface'
 import OptionsPanel from './OptionsPanel'
-import { useAppDispatch, useAppSelector } from '@/app/lib/redux/hooks'
+import { useAppDispatch } from '@/app/lib/redux/hooks'
 import { toggleShowLoginModalValue } from '@/app/lib/redux/features/loginModal'
 
 export default function MediaActionOptionsButton({ mediaInfo }: { mediaInfo: ApiDefaultResult }) {

diff --git a/app/layout/header/components/MangaNavListHover/index.tsx b/app/layout/header/components/MangaNavListHover/index.tsx
@@ -107,6 +107,7 @@ function MangaNavListHover() {
                                     <MediaCard.Container>
 
                                         <MediaCard.MediaImgLink
+                                            mediaInfo={media}
                                             mediaId={media.id}
                                             title={media.title.userPreferred}
                                             formatOrType={media.format}