-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: VAIS Web Result Summarize using Gemini Notebook #1500
feat: VAIS Web Result Summarize using Gemini Notebook #1500
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
We have some notebooks already with similar workflows here https://github.com/GoogleCloudPlatform/generative-ai/tree/main/search/retrieval-augmented-generation/examples Could you see about adding this to the Question Answering Notebook? Or maybe the RAG Google Documentation one? |
Hi Holt, Thank you for reviewing this pull request and for your feedback. The notebook differs from the typical RAG workflow. In this implementation, I am using the Discovery Engine API to connect to a Vertex AI Search website datastore. It fetches matching results for a user query and extracts the top result URL. The workflow then makes an HTTP request to the URL to retrieve the webpage content, which is sent to Gemini for summarization. This approach does not rely on advanced indexing of the webpage. Given its alignment with Vertex AI Search workflows, I felt it was more suitable to place it under the search folder. However, if you believe it would be better suited under the Question Answering or RAG Google Documentation folders, I’m happy to move it there. Please let me know your thoughts. I appreciate your insights and guidance. Thank you again for your feedback! @holtskinner |
ef26e87
to
840d608
Compare
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTING
Guide.CODEOWNERS
for the file(s).nox -s format
from the repository root to format).Fixes #<issue_number_goes_here> 🦕