Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Notebook for RAG Engine with Vertex AI Search #1527

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

galexdor
Copy link
Contributor

@galexdor galexdor commented Dec 12, 2024

@galexdor galexdor requested a review from a team as a code owner December 12, 2024 18:35
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @galexdor and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request adds a new Jupyter notebook demonstrating how to use the Vertex AI RAG Engine with Vertex AI Search as the retrieval backend. The notebook covers setting up a Vertex AI Search datastore and engine (optional, if you already have one), creating a RAG corpus using the Vertex AI Search engine, and then using the Gemini GenerateContent API and other generation APIs with the RAG retrieval tool. The intent is to provide a practical example of integrating Vertex AI Search into a RAG application for improved scalability and performance. The main changes include the addition of a new notebook (gemini/rag-engine/rag_engine_vertex_ai_search.ipynb), and an update to the rag-grounding/README.md file to include a link to this new notebook.

The notebook is well-structured and clearly explains each step of the process. It also includes helpful comments and explanations throughout the code. The addition of this notebook significantly enhances the documentation and provides a valuable resource for developers looking to build RAG applications with Vertex AI Search.

To celebrate this addition to the generative-ai repository, here's a little haiku:

Search lights up the way,
Knowledge flows, a bright new path,
RAG finds its true form.

Thanks!

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request introduces a new notebook demonstrating how to use the Vertex AI RAG Engine with Vertex AI Search. The notebook is well-structured, easy to follow, and the code appears correct. The explanations and helper functions are helpful for users. A few minor suggestions are included below.

Copy link
Collaborator

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can add this to the Docs page

@holtskinner holtskinner merged commit 9b4518d into GoogleCloudPlatform:main Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants