Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GSP1150 - Getting Started with the Gemini 1.5 Pro Model in Vertex AI Bug (intro_gemini_1_5_pro.ipynb) #1562

Merged

Conversation

hemantsinalkar-ssk
Copy link
Contributor

@hemantsinalkar-ssk hemantsinalkar-ssk commented Dec 19, 2024

  • Updated the order of contents to generate the required response
  • Buganizer : http://b/383794207

@hemantsinalkar-ssk hemantsinalkar-ssk requested a review from a team as a code owner December 19, 2024 08:25
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:

This pull request updates the intro_gemini_1_5_pro.ipynb notebook, addressing a bug reported in Buganizer (http://b/383794207). The primary change involves reordering the elements within the contents list used for content generation with the Gemini 1.5 Pro model in Vertex AI.

Specifically:

  • Intent: To fix a bug in the order of processing inputs (prompt, PDF, image) for the Gemini 1.5 Pro model.
  • Changes: The order of prompt, pdf_file, and image_file within the contents list in the code snippet (lines 734-742 of gemini/getting-started/intro_gemini_1_5_pro.ipynb) has been altered. The prompt is now placed before the pdf_file and image_file.

The updated order likely improves the model's processing and output, addressing the reported bug. I'll provide a more detailed review shortly, including testing the changes.


A little haiku to lighten the mood:

Code flows like a stream,
Bugs are rocks that block the path,
Review clears the way.

Thanks,
Gemini

Copy link
Contributor

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@hemantsinalkar-ssk
Copy link
Contributor Author

@code-review-assist review

Copy link
Contributor

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@holtskinner holtskinner changed the title Notebook Updates : GSP1150 - Getting Started with the Gemini 1.5 Pro Model in Vertex AI Bug (intro_gemini_1_5_pro.ipynb) fix: GSP1150 - Getting Started with the Gemini 1.5 Pro Model in Vertex AI Bug (intro_gemini_1_5_pro.ipynb) Dec 19, 2024
@holtskinner holtskinner merged commit d451b78 into GoogleCloudPlatform:main Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants