Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add translate dev team for translate samples #13013

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

iennae
Copy link
Contributor

@iennae iennae commented Dec 21, 2024

Description

b/385243174

@iennae iennae requested review from a team as code owners December 21, 2024 00:34
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 21, 2024
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iennae and reviewers,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, as the title suggests, adds a translate dev team to the CODEOWNERS file. The intent is to assign ownership of the translation samples to the appropriate team.

Specifically, the change adds a new line to the .github/CODEOWNERS file at line 91:

/translate                             @GoogleCloudPlatform/python-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers @GoogleCloudPlatform/cloud-ml-translate-dev

This line assigns the /translate directory to the @GoogleCloudPlatform/python-samples-reviewers, @GoogleCloudPlatform/cloud-samples-reviewers, and @GoogleCloudPlatform/cloud-ml-translate-dev teams. This ensures that the correct individuals are notified of changes and can review pull requests related to the translation samples.

Looking forward to a smooth review!

And now, a little haiku to lighten the mood:

Code flows like a stream,
Reviewers guide the careful path,
Quality takes flight.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@davidcavazos davidcavazos merged commit 9531bf4 into main Dec 21, 2024
13 checks passed
@davidcavazos davidcavazos deleted the iennae-patch-1 branch December 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants