Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency apache-airflow-providers-apache-beam to v6 #13018

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# be sure to update the constraints file to match
# see https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#constraints-files
Comment on lines 1 to 2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

While the comment about updating the constraints file is helpful, the link to the Airflow documentation is more generally useful for managing dependencies. Consider rephrasing this comment to be more specific to this requirements.txt file, or removing it altogether if it's redundant with the top-level documentation. Per the style guide, "Each sample should have a README.md file that provides instructions for how to install, configure, and run the sample."

Suggested change
# be sure to update the constraints file to match
# see https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#constraints-files
# Dependencies for data orchestration blog sample

apache-airflow[google]==2.6.3
apache-airflow-providers-apache-beam==5.1.1
apache-airflow-providers-apache-beam==6.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding a comment explaining why this specific version of apache-airflow-providers-apache-beam is required. This will help with future maintainability and understanding the context of this dependency. Per the style guide, prefer descriptive comments and docstrings.

Suggested change
apache-airflow-providers-apache-beam==6.0.0
apache-airflow-providers-apache-beam==6.0.0 # Updated for compatibility with ...

apache-airflow-providers-slack==7.3.1
apache-airflow-providers-http==4.4.2