Skip to content

Commit

Permalink
Revert "Move widget picker tests to Robolectric"
Browse files Browse the repository at this point in the history
This reverts commit efc24f9.

Reason for revert: Potential cause for flakiness https://android-build.corp.google.com/test_investigate/?invocationId=I07000010279081631&testResultId=TR32129311605132927

Change-Id: I4f0154bc101b6bc840c11ff0b6bf42f4ebc5ed03
  • Loading branch information
uwaisashraf authored and Android (Google) Code Review committed May 21, 2024
1 parent efc24f9 commit 97ee134
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@
*/
package com.android.launcher3.util;

import static androidx.test.core.app.ApplicationProvider.getApplicationContext;
import static androidx.test.platform.app.InstrumentationRegistry.getInstrumentation;

import android.appwidget.AppWidgetManager;
import android.appwidget.AppWidgetProviderInfo;
import android.content.ComponentName;
import android.content.Context;
import android.content.pm.ActivityInfo;
import android.content.pm.ApplicationInfo;
import android.os.Bundle;
import android.os.Process;

import com.android.launcher3.LauncherSettings;
import com.android.launcher3.model.data.LauncherAppWidgetInfo;
Expand Down Expand Up @@ -84,10 +87,10 @@ public static LauncherAppWidgetInfo createWidgetInfo(
* Creates a {@link AppWidgetProviderInfo} for the provided component name
*/
public static AppWidgetProviderInfo createAppWidgetProviderInfo(ComponentName cn) {
ActivityInfo activityInfo = new ActivityInfo();
activityInfo.applicationInfo = new ApplicationInfo();
AppWidgetProviderInfo info = new AppWidgetProviderInfo();
info.providerInfo = activityInfo;
AppWidgetProviderInfo info = AppWidgetManager.getInstance(getApplicationContext())
.getInstalledProvidersForPackage(
getInstrumentation().getContext().getPackageName(), Process.myUserHandle())
.get(0);
info.provider = cn;
return info;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import static android.content.pm.ApplicationInfo.CATEGORY_VIDEO;
import static android.content.pm.ApplicationInfo.FLAG_INSTALLED;

import static androidx.test.core.app.ApplicationProvider.getApplicationContext;
import static androidx.test.platform.app.InstrumentationRegistry.getInstrumentation;

import static com.google.common.truth.Truth.assertThat;
Expand All @@ -34,6 +35,7 @@
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.when;

import android.appwidget.AppWidgetManager;
import android.appwidget.AppWidgetProviderInfo;
import android.content.ComponentName;
import android.content.Context;
Expand All @@ -51,7 +53,6 @@
import com.android.launcher3.icons.IconCache;
import com.android.launcher3.model.WidgetItem;
import com.android.launcher3.util.Executors;
import com.android.launcher3.util.WidgetUtils;
import com.android.launcher3.widget.LauncherAppWidgetProviderInfo;

import com.google.common.collect.ImmutableMap;
Expand Down Expand Up @@ -151,8 +152,11 @@ private void createTestWidgetItem() {

doAnswer(invocation -> widgetLabel).when(mIconCache).getTitleNoCache(any());

AppWidgetProviderInfo providerInfo = WidgetUtils.createAppWidgetProviderInfo(ComponentName
.createRelative(TEST_PACKAGE, widgetClassName));
AppWidgetProviderInfo providerInfo = AppWidgetManager.getInstance(getApplicationContext())
.getInstalledProvidersForPackage(
getInstrumentation().getContext().getPackageName(), Process.myUserHandle())
.get(0);
providerInfo.provider = ComponentName.createRelative(TEST_PACKAGE, widgetClassName);

LauncherAppWidgetProviderInfo launcherAppWidgetProviderInfo =
LauncherAppWidgetProviderInfo.fromProviderInfo(mContext, providerInfo);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package com.android.launcher3.widget.picker.search;

import static androidx.test.core.app.ApplicationProvider.getApplicationContext;
import static androidx.test.platform.app.InstrumentationRegistry.getInstrumentation;

import static com.android.launcher3.util.Executors.MAIN_EXECUTOR;
import static com.android.launcher3.util.WidgetUtils.createAppWidgetProviderInfo;
Expand Down Expand Up @@ -164,7 +163,7 @@ public void doSearch_shouldInformCallback() throws Exception {
.when(mDataProvider)
.getAllWidgets();
mSimpleWidgetsSearchAlgorithm.doSearch("Ca", mSearchCallback);
getInstrumentation().waitForIdleSync();
MAIN_EXECUTOR.submit(() -> { }).get();
verify(mSearchCallback).onSearchResult(
matches("Ca"), argThat(a -> a != null && !a.isEmpty()));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class WidgetPreviewContainerSizesTest {
private lateinit var context: Context
private lateinit var deviceProfile: DeviceProfile
private lateinit var testInvariantProfile: InvariantDeviceProfile
private lateinit var widgetItemInvariantProfile: InvariantDeviceProfile

@Mock private lateinit var iconCache: IconCache

Expand All @@ -52,11 +51,6 @@ class WidgetPreviewContainerSizesTest {
MockitoAnnotations.initMocks(this)
context = ActivityContextWrapper(ApplicationProvider.getApplicationContext())
testInvariantProfile = LauncherAppState.getIDP(context)
widgetItemInvariantProfile =
InvariantDeviceProfile().apply {
numRows = TEST_GRID_SIZE
numColumns = TEST_GRID_SIZE
}
deviceProfile = testInvariantProfile.getDeviceProfile(context).copy(context)
}

Expand All @@ -66,8 +60,7 @@ class WidgetPreviewContainerSizesTest {
val expectedPreviewContainers = testSizes.values.toList()

for ((index, widgetSize) in testSizes.keys.withIndex()) {
val widgetItem =
createWidgetItem(widgetSize, context, widgetItemInvariantProfile, iconCache)
val widgetItem = createWidgetItem(widgetSize, context, testInvariantProfile, iconCache)

assertWithMessage("size for $widgetSize should be: ${expectedPreviewContainers[index]}")
.that(WidgetPreviewContainerSize.forItem(widgetItem, deviceProfile))
Expand All @@ -77,7 +70,6 @@ class WidgetPreviewContainerSizesTest {

companion object {
private const val TEST_PACKAGE = "com.google.test"
private const val TEST_GRID_SIZE = 6

private val HANDHELD_TEST_SIZES: Map<Point, WidgetPreviewContainerSize> =
mapOf(
Expand Down

0 comments on commit 97ee134

Please sign in to comment.