Fix issue when truncating unicode text (php-tui#215)

* Fix issue when truncating unicode text * Update CHANGELOG.md
GreenCape · Dec 3, 2023 · 2da2df8 · 2da2df8
1 parent 2c5b673
commit 2da2df8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,7 +17,8 @@ Refactoring:
 Bug fixes:
 
 - Fix block adjacent border renderering #201
-- Fix `StyledGrapheme` symbol width #214
+- Fix `StyledGrapheme` symbol width #214 @KennedyTedesco
+- Fix issue when truncating unicode text #215 @KennedyTedesco
 
 ## 0.1.0
 

diff --git a/src/Text/LineComposer/LineTruncator.php b/src/Text/LineComposer/LineTruncator.php
@@ -61,7 +61,7 @@ public function nextLine(): Generator
                 );
 
                 $currentLine[] = new StyledGrapheme($symbol, $styledGrapheme->style);
-                $currentLineWidth += mb_strlen($symbol);
+                $currentLineWidth += mb_strwidth($symbol);
             }
             yield [
                 $currentLine,

diff --git a/tests/Unit/Extension/Core/Widget/ParagraphRendererTest.php b/tests/Unit/Extension/Core/Widget/ParagraphRendererTest.php
@@ -35,6 +35,7 @@ public function testFromMultilineString(): void
             'Goodbye   ',
         ], $buffer->toLines());
     }
+
     /**
      * @dataProvider provideParagraph
      */
@@ -46,8 +47,8 @@ public function testParagraph(
         $buffer = Buffer::empty($area);
         $this->render($buffer, $paragraph);
         self::assertEquals($expected, $buffer->toString());
-
     }
+
     /**
      * @return Generator<string,array{Area,ParagraphWidget,string}>
      */
@@ -85,5 +86,12 @@ public static function provideParagraph(): Generator
             '1/1       ',
             '     About',
         ];
+        yield 'unicode' => [
+            Area::fromDimensions(14, 1),
+            ParagraphWidget::fromText(
+                Text::fromString('こんにちは, 世界! 😃')
+            ),
+            'こんにちは, 世',
+        ];
     }
 }