Merge pull request activepieces#2570 from activepieces/fix/s3-1

fix(amazon-s3): invalid url when endpoint is empty is fixed
GunnerJnr · Sep 8, 2023 · 91ec9dd · 91ec9dd
2 parents 8dced24 + c8e6c1c
commit 91ec9dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/pieces/amazon-s3/package.json b/packages/pieces/amazon-s3/package.json
@@ -1,4 +1,4 @@
 {
   "name": "@activepieces/piece-amazon-s3",
-  "version": "0.3.0"
+  "version": "0.3.1"
 }
diff --git a/packages/pieces/amazon-s3/src/lib/common.ts b/packages/pieces/amazon-s3/src/lib/common.ts
@@ -1,3 +1,4 @@
+import { isNil } from "@activepieces/shared";
 import { S3 } from "@aws-sdk/client-s3";
 
 
@@ -7,9 +8,9 @@ export function createS3(auth: { accessKeyId: string; secretAccessKey: string; r
             accessKeyId: auth.accessKeyId,
             secretAccessKey: auth.secretAccessKey,
         },
-        forcePathStyle: auth.endpoint ? true : false,
+        forcePathStyle: auth.endpoint ? true : undefined,
         region: auth.region,
-        endpoint: auth.endpoint,
+        endpoint:(auth.endpoint === '' || isNil(auth.endpoint))  ? undefined : auth.endpoint,
     });
     return s3;
 }