Clean up sink tests

This commit refactors sink_test:
1. Common setup/comparison extracted to helper methods
2. Removes some redundant params from the test resources
3. Remove the test that checks that we respond in 1s or less.
Since we are using fake clients in these examples, this test is
not as useful as it being in an e2e test.

Part of tektoncd#394

Signed-off-by: Dibyo Mukherjee <[email protected]>

pkg/sink/initialization.go

@@ -31,9 +31,9 @@ import (
 
 const (
 	// Flag definitions
-	name      = "el-name"
-	namespace = "el-namespace"
-	port      = "port"
+	name        = "el-name"
+	elNamespace = "el-namespace"
+	port        = "port"
 )
 
 var (
@@ -71,7 +71,7 @@ func GetArgs() (Args, error) {
 		return Args{}, xerrors.Errorf("-%s arg not found", name)
 	}
 	if *namespaceFlag == "" {
-		return Args{}, xerrors.Errorf("-%s arg not found", namespace)
+		return Args{}, xerrors.Errorf("-%s arg not found", elNamespace)
 	}
 	if *portFlag == "" {
 		return Args{}, xerrors.Errorf("-%s arg not found", port)

pkg/sink/initialization_test.go

@@ -25,7 +25,7 @@ func Test_GetArgs(t *testing.T) {
 	if err := flag.Set(name, "elname"); err != nil {
 		t.Errorf("Error setting flag el-name: %s", err)
 	}
-	if err := flag.Set(namespace, "elnamespace"); err != nil {
+	if err := flag.Set(elNamespace, "elnamespace"); err != nil {
 		t.Errorf("Error setting flag el-namespace: %s", err)
 	}
 	if err := flag.Set(port, "port"); err != nil {