Skip to content

Commit

Permalink
[CodeHealth] Remove RAW_PTR_EXCLUSION from test IPC::Listeners
Browse files Browse the repository at this point in the history
Bug: 346694204, 346693740
Change-Id: I299e619cdc43bb59d954f0c059f3688161ebe706
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5650558
Reviewed-by: Ken Rockot <[email protected]>
Commit-Queue: Alex Yang <[email protected]>
Code-Coverage: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1318837}
  • Loading branch information
Alex Yang authored and Chromium LUCI CQ committed Jun 24, 2024
1 parent 64eeaa0 commit 485058d
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions ipc/ipc_channel_proxy_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "base/memory/raw_ptr.h"
#include "base/memory/raw_ptr_exclusion.h"
#include "build/build_config.h"

#include <stddef.h>
#include <stdint.h>

#include <memory>

#include "base/memory/raw_ptr.h"
#include "base/message_loop/message_pump_type.h"
#include "base/pickle.h"
#include "base/run_loop.h"
#include "base/task/single_thread_task_runner.h"
#include "base/threading/thread.h"
#include "build/build_config.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_test_base.h"
#include "ipc/message_filter.h"
Expand Down Expand Up @@ -49,7 +47,7 @@ namespace IPC {

namespace {

void CreateRunLoopAndRun(base::RunLoop** run_loop_ptr) {
void CreateRunLoopAndRun(raw_ptr<base::RunLoop>* run_loop_ptr) {
base::RunLoop run_loop;
*run_loop_ptr = &run_loop;
run_loop.Run();
Expand Down Expand Up @@ -86,8 +84,7 @@ class QuitListener : public IPC::Listener {

bool bad_message_received_ = false;
bool quit_message_received_ = false;
// RAW_PTR_EXCLUSION: #addr-of
RAW_PTR_EXCLUSION base::RunLoop* run_loop_ = nullptr;
raw_ptr<base::RunLoop> run_loop_ = nullptr;
};

class ChannelReflectorListener : public IPC::Listener {
Expand Down Expand Up @@ -129,8 +126,7 @@ class ChannelReflectorListener : public IPC::Listener {
run_loop_->QuitWhenIdle();
}

// RAW_PTR_EXCLUSION: #addr-of
RAW_PTR_EXCLUSION base::RunLoop* run_loop_ = nullptr;
raw_ptr<base::RunLoop> run_loop_ = nullptr;

private:
raw_ptr<IPC::Channel> channel_ = nullptr;
Expand Down

0 comments on commit 485058d

Please sign in to comment.