Do not append & to internal Expenisfy URLs that have a # symbol.

Habben101 · Jun 14, 2022 · a0cf4b2 · a0cf4b2
1 parent a32065c
commit a0cf4b2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/libs/actions/Link.js b/src/libs/actions/Link.js
@@ -39,7 +39,11 @@ function openOldDotLink(url) {
     }
 
     function buildOldDotURL({shortLivedAuthToken}) {
-        return `${CONFIG.EXPENSIFY.EXPENSIFY_URL}${url}${url.indexOf('?') === -1 ? '?' : '&'}authToken=${shortLivedAuthToken}&email=${encodeURIComponent(currentUserEmail)}`;
+        const hasHashParams = url.indexOf('#') !== -1;
+        const hasURLParams = url.indexOf('?') !== -1;
+
+        // If the URL contains # or ?, we can assume they don't need to have the `?` token to start listing url parameters.
+        return `${CONFIG.EXPENSIFY.EXPENSIFY_URL}${url}${hasHashParams || hasURLParams ? '&' : '?'}authToken=${shortLivedAuthToken}&email=${encodeURIComponent(currentUserEmail)}`;
     }
 
     asyncOpenURL(DeprecatedAPI.GetShortLivedAuthToken(), buildOldDotURL);