Correctly disallow var declarations with init in for-of loops

Hahet · Mar 26, 2019 · 07c7202 · 07c7202
1 parent b406e91
commit 07c7202
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/acorn/src/statement.js b/acorn/src/statement.js
@@ -452,6 +452,7 @@ pp.parseForIn = function(node, init) {
     init.type === "VariableDeclaration" &&
     init.declarations[0].init != null &&
     (
+      !isForIn ||
       this.options.ecmaVersion < 8 ||
       this.strict ||
       init.kind !== "var" ||

diff --git a/test/tests-harmony.js b/test/tests-harmony.js
@@ -13121,6 +13121,7 @@ testFail("for (const x = 42 in list) process(x);", "for-in loop variable declara
 testFail("for (let x = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 6});
 testFail("for (const x = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 6});
 testFail("for (var x = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 6});
+testFail("for (var x = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 8});
 testFail("for (var {x} = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 6});
 testFail("for (var [x] = 42 of list) process(x);", "for-of loop variable declaration may not have an initializer (1:5)", {ecmaVersion: 6});
 testFail("var x; for (x = 42 of list) process(x);", "Invalid left-hand side in for-loop (1:12)", {ecmaVersion: 6});