-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Setting the start position #21
Feature: Setting the start position #21
Conversation
@HamzaGhazouani will you be able to review and approve this PR? |
Hi @spaluchiewicz, thanks for your contribution, I will look at it soon, it will be nice if we add an example of this feature in the sample |
Sure, I will update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @spaluchiewicz,
Thanks for your contribution.
We should do some changes before the merge:
- Add documentation to
circleInitialAngle
property - Add documentation and explanation to
func rotate(around center: CGPoint, with degrees: CGFloat)
, the second parameter is in radian and not degrees. - We should not modify the
CircularSliderHelper.circleInitialAngle
because it can be used by other instances of circular slider and we will get errors (we should remove it and use an instance property instead)
For the example, we can just change the initial angle of the last example (circular) in the tab bar
Thanks
Hi, can I help wrap this up? |
Hi @iblagajic, |
Should I create a new PR or can I contribute to the existing one? |
@iblagajic as you prefer :) |
This PR is to solve #20 (Setting the start position)