Typescript #70
Merged
Typescript #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corsicanec82
requested changes
Jun 15, 2023
There was a problem hiding this comment.
В целом каких то серьёзных проблем не вижу.
Есть несколько небольших замечаний и вопросов (они в ревью)
Из важного: стоит поработать над варнингом (возможно скрыть его или использовать рекомендуемую версию). Так как он будет занимать полный вывод в практике и смущать пользователей
Также порекомендую поставить отдельную задачу по обновлению версий зависимостей. Но тут лучше будет вначале обновить зависимости в базовом образе (кстати давно уже этого не было)
corsicanec82
requested changes
Jun 16, 2023
improve js linter config
corsicanec82
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.