[svg] Conditional debugging

Use SkDEBUGF, which can be disabled, instead of always-on SkDebugf.

Bug: b/374627499
Change-Id: I6852357935cfe3c0058f5b23f7362b97235bc404
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/912956
Reviewed-by: Nicolette Prevost <[email protected]>
Reviewed-by: Florin Malita <[email protected]>
Commit-Queue: Florin Malita <[email protected]>

modules/svg/include/SkSVGFeLightSource.h

@@ -20,7 +20,7 @@
 class SK_API SkSVGFeLightSource : public SkSVGHiddenContainer {
 public:
     void appendChild(sk_sp<SkSVGNode>) final {
-        SkDebugf("cannot append child nodes to an SVG light source.\n");
+        SkDEBUGF("cannot append child nodes to an SVG light source.\n");
     }
 
 protected:

modules/svg/include/SkSVGImage.h

@@ -31,7 +31,7 @@ class SK_API SkSVGImage final : public SkSVGTransformableNode {
     }
 
     void appendChild(sk_sp<SkSVGNode>) override {
-        SkDebugf("cannot append child nodes to this element.\n");
+        SkDEBUGF("cannot append child nodes to this element.\n");
     }
 
     bool onPrepareToRender(SkSVGRenderContext*) const override;

modules/svg/src/SkSVGFeFlood.cpp

@@ -21,7 +21,7 @@ SkColor SkSVGFeFlood::resolveFloodColor(const SkSVGRenderContext& ctx) const {
     const auto floodOpacity = this->getFloodOpacity();
     // Uninherited presentation attributes should have a concrete value by now.
     if (!floodColor.isValue() || !floodOpacity.isValue()) {
-        SkDebugf("unhandled: flood-color or flood-opacity has no value\n");
+        SkDEBUGF("unhandled: flood-color or flood-opacity has no value\n");
         return SK_ColorBLACK;
     }
 

modules/svg/src/SkSVGFeLighting.cpp

@@ -58,15 +58,15 @@ sk_sp<SkImageFilter> SkSVGFeLighting::onMakeImageFilter(const SkSVGRenderContext
         }
     }
 
-    SkDebugf("lighting filter effect needs exactly one light source\n");
+    SkDEBUGF("lighting filter effect needs exactly one light source\n");
     return nullptr;
 }
 
 SkColor SkSVGFeLighting::resolveLightingColor(const SkSVGRenderContext& ctx) const {
     const auto color = this->getLightingColor();
     if (!color.isValue()) {
         // Uninherited presentation attributes should have a concrete value by now.
-        SkDebugf("unhandled: lighting-color has no value\n");
+        SkDEBUGF("unhandled: lighting-color has no value\n");
         return SK_ColorWHITE;
     }
 

modules/svg/src/SkSVGFilterContext.cpp

@@ -138,7 +138,7 @@ std::tuple<sk_sp<SkImageFilter>, SkSVGColorspace> SkSVGFilterContext::getInput(
             break;
         }
         default:
-            SkDebugf("unhandled filter input type %d\n", (int)inputType.type());
+            SkDEBUGF("unhandled filter input type %d\n", (int)inputType.type());
             break;
     }
 

modules/svg/src/SkSVGGradient.cpp

@@ -64,7 +64,7 @@ SkColor4f SkSVGGradient::resolveStopColor(const SkSVGRenderContext& ctx,
     const auto& stopOpacity = stop.getStopOpacity();
     // Uninherited presentation attrs should have a concrete value at this point.
     if (!stopColor.isValue() || !stopOpacity.isValue()) {
-        SkDebugf("unhandled: stop-color or stop-opacity has no value\n");
+        SkDEBUGF("unhandled: stop-color or stop-opacity has no value\n");
         return SkColors::kBlack;
     }
 

modules/svg/src/SkSVGImage.cpp

@@ -54,7 +54,7 @@ static sk_sp<SkImage> LoadImage(const sk_sp<skresources::ResourceProvider>& rp,
             break;
         }
         default:
-            SkDebugf("error loading image: unhandled iri type %d\n", (int)href.type());
+            SkDEBUGF("error loading image: unhandled iri type %d\n", (int)href.type());
             return nullptr;
     }
 
@@ -90,7 +90,7 @@ void SkSVGImage::onRender(const SkSVGRenderContext& ctx) const {
 
     const auto imgInfo = LoadImage(ctx.resourceProvider(), fHref, viewPort, fPreserveAspectRatio);
     if (!imgInfo.fImage) {
-        SkDebugf("can't render image: load image failed\n");
+        SkDEBUGF("can't render image: load image failed\n");
         return;
     }
 

modules/svg/src/SkSVGRenderContext.cpp

@@ -80,7 +80,7 @@ SkScalar SkSVGLengthContext::resolve(const SkSVGLength& l, LengthType t) const {
     case SkSVGLength::Unit::kPC:
         return l.value() * fDPI * kPCMultiplier;
     default:
-        SkDebugf("unsupported unit type: <%d>\n", (int)l.unit());
+        SkDEBUGF("unsupported unit type: <%d>\n", (int)l.unit());
         return 0;
     }
 }
@@ -210,7 +210,7 @@ SkSVGRenderContext::~SkSVGRenderContext() {
 
 SkSVGRenderContext::BorrowedNode SkSVGRenderContext::findNodeById(const SkSVGIRI& iri) const {
     if (iri.type() != SkSVGIRI::Type::kLocal) {
-        SkDebugf("non-local iri references not currently supported");
+        SkDEBUGF("non-local iri references not currently supported");
         return BorrowedNode(nullptr);
     }
     return BorrowedNode(fIDMapper.find(iri.iri()));
@@ -493,7 +493,7 @@ SkSVGColorType SkSVGRenderContext::resolveSvgColor(const SkSVGColor& color) cons
         case SkSVGColor::Type::kCurrentColor:
             return *fPresentationContext->fInherited.fColor;
         case SkSVGColor::Type::kICCColor:
-            SkDebugf("ICC color unimplemented");
+            SkDEBUGF("ICC color unimplemented");
             return SK_ColorBLACK;
     }
     SkUNREACHABLE;

modules/svg/src/SkSVGShape.cpp

@@ -36,5 +36,5 @@ void SkSVGShape::onRender(const SkSVGRenderContext& ctx) const {
 }
 
 void SkSVGShape::appendChild(sk_sp<SkSVGNode>) {
-    SkDebugf("cannot append child nodes to an SVG shape.\n");
+    SkDEBUGF("cannot append child nodes to an SVG shape.\n");
 }

modules/svg/src/SkSVGUse.cpp

@@ -16,7 +16,7 @@
 SkSVGUse::SkSVGUse() : INHERITED(SkSVGTag::kUse) {}
 
 void SkSVGUse::appendChild(sk_sp<SkSVGNode>) {
-    SkDebugf("cannot append child nodes to this element.\n");
+    SkDEBUGF("cannot append child nodes to this element.\n");
 }
 
 bool SkSVGUse::parseAndSetAttribute(const char* n, const char* v) {