Skip to content

Commit

Permalink
Do not export SkTDArray when building Skia as a DLL
Browse files Browse the repository at this point in the history
This class has four members (deleteAll, freeAll, unrefAll and
safeUnrefAll) which will only compile for certain instantiations of
SkTDArray depending on the template argument type.  Marking this class
as dllexport breaks the build with clang-cl because of
http://llvm.org/PR20163.  Since this class is header-only, we can just
make it non-exported to enable building Skia as a DLL with clang-cl.

BUG=skia:
[email protected], [email protected], [email protected]

Author: [email protected]

Review URL: https://codereview.chromium.org/368253002
  • Loading branch information
ehsan authored and Commit bot committed Jul 9, 2014
1 parent 2d9d9c9 commit db5f7bf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

ACCESS CO., LTD. <*@access-company.com>
ARM <*@arm.com>
Ehsan Akhgari <[email protected]>
George Wright <[email protected]>
Google Inc. <*@google.com>
Igalia <*@igalia.com>
Expand Down
2 changes: 1 addition & 1 deletion include/core/SkTDArray.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

#include "SkTypes.h"

template <typename T> class SK_API SkTDArray {
template <typename T> class SkTDArray {
public:
SkTDArray() {
fReserve = fCount = 0;
Expand Down

0 comments on commit db5f7bf

Please sign in to comment.