Update CustomSVGSeries to use getX / getY (uber#1051)

* Update CustomSVGSeries to use getX / getY * Updated an example to showcase getX / getY
HynesIP · Dec 31, 2018 · c820b41 · c820b41
1 parent cb40485
commit c820b41
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/showcase/plot/custom-svg-example.js b/showcase/plot/custom-svg-example.js
@@ -31,7 +31,7 @@ import {
 
 export default function Example(props) {
   return (
-    <XYPlot width={300} height={300}>
+    <XYPlot width={300} height={300} getY={d => d.value}>
       <VerticalGridLines />
       <HorizontalGridLines />
       <XAxis />
@@ -40,13 +40,13 @@ export default function Example(props) {
         className="custom-marking"
         customComponent="square"
         data={[
-          {x: 1, y: 10, customComponent: 'circle', size: 10},
-          {x: 1.7, y: 12, size: 20, style: {stroke: 'red', fill: 'orange'}},
-          {x: 2, y: 5},
-          {x: 3, y: 15},
+          {x: 1, value: 10, customComponent: 'circle', size: 10},
+          {x: 1.7, value: 12, size: 20, style: {stroke: 'red', fill: 'orange'}},
+          {x: 2, value: 5},
+          {x: 3, value: 15},
           {
             x: 2.5,
-            y: 7,
+            value: 7,
             customComponent: (row, positionInPixels, globalStyle) => {
               return (
                 <g className="inner-inner-component">

diff --git a/src/plot/series/custom-svg-series.js b/src/plot/series/custom-svg-series.js
@@ -140,8 +140,8 @@ class CustomSVGSeries extends AbstractSeries {
     const y = this._getAttributeFunctor('y');
     const contents = data.map((seriesComponent, index) => {
       const positionInPixels = {
-        x: x({x: seriesComponent.x}),
-        y: y({y: seriesComponent.y})
+        x: x(seriesComponent),
+        y: y(seriesComponent)
       };
       const innerComponent = getInnerComponent({
         customComponent: seriesComponent,