Single Packages (0.2.2.dev1) for data-prep-toolkit and data-prep-toolkit-transforms with python3.12 #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
… need to install the rquirements.txt seperately Signed-off-by: Maroun Touma <[email protected]>
…nsforms folder Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Consistency of installing new pip installs
New pip install option for Ray
Use "all" option for the new pip install
…dividually for testing Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
touma-I
changed the title
Need to change to the new format of [ray]
…it into dev1-singlepackage-p3.12
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
daw3rd
requested changes
Oct 9, 2024
.make.defaults
Outdated
| @@ -234,6 +234,7 @@ __check_defined = \ | |||
| mkdir ${LIB_NAME} | |||
| cp -p -R ${LIB_PATH}/src ${LIB_NAME} | |||
| cp -p -R ${LIB_PATH}/pyproject.toml ${LIB_NAME} | |||
| -cp -p -R ${LIB_PATH}/requirements.txt ${LIB_NAME} | |||
There was a problem hiding this comment.
this looks redundant with the if 2 lines down.
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
daw3rd
requested changes
Oct 11, 2024
Signed-off-by: Maroun Touma <[email protected]>
daw3rd
approved these changes
Oct 11, 2024
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In this release, we create a single pypi package for data-prep-kit[dev,ray,spark] and a single data-prep-kit-transforms[all,ray,code_quality,doc_id,etc]
This replaces the multitude of packages we currently have and can be installed using:
pip install data-prep-toolkit==0.2.2.dev1
pip install 'data-prep-toolkit[ray]==0.2.2.dev1'
pip install 'data-prep-toolkit-transforms[ray, all]==0.2.2.dev1'
Related issue number (if any).
#673