Minor change to kfp workflow. #684
Conversation
revit13
force-pushed
the
kfp-workflow1
branch
2 times, most recently
from
d568e3d
to
2490495
Compare
| echo "Skipping transforms/code/code_quality kfp test for lack of Makefile and/or kfp_ray/Makefile" | ||
| transform=$(basename "transforms/code/code_quality") | ||
| if echo ${KFP_BLACK_LIST} | grep -qv ${transform}; then | ||
| $PWD/scripts/workflow_helper.sh install-tools |
There was a problem hiding this comment.
can we have makefile targets that call these? This would then allow the developer to run these tests locally, more easily and through mechanisms they are already familiar with (i.e. make).
There was a problem hiding this comment.
This would also force all the kfp tests to be run - they are not in the current PR . See that only 3 checks were run.
There was a problem hiding this comment.
Would it be okay to address this in a separate issue? Personally, I'm not in favor of this approach because this install-tools function works specifically for Ubuntu, as used in the GitHub Action. The installation process differs for other operating systems, like macOS, with its various versions. I believe it would be simpler for each person to deploy or use their own tools on their machine, rather than creating a new script that we would need to maintain. However, I could be wrong on this...
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
revit13
force-pushed
the
kfp-workflow1
branch
5 times, most recently
from
c8cd68d
to
3883fec
Compare
revit13
force-pushed
the
kfp-workflow1
branch
3 times, most recently
from
7214892
to
f3bb600
Compare
Signed-off-by: Revital Sur <[email protected]>
Following request from @roytman and @daw3rd this pr tries to merge common parts in kfp workflow different steps.
In addition this PR builds the workflow even if its part of the workflow's black list.