added tekton task for Code Engine Deploy #277 #128
Conversation
tasks/12-ibm-codeengine-deploy.yaml
Outdated
| image: $(params.tools-image) | ||
| workingdir: $(params.source-dir) | ||
| env: | ||
| - name: NAMESPACE |
There was a problem hiding this comment.
Remove this environment variable. It isn't used by the task
tasks/12-ibm-codeengine-deploy.yaml
Outdated
| - name: image-to | ||
| type: string | ||
| - name: tools-image | ||
| default: garagecatalyst/ibmcloud-dev:1.1.3 |
There was a problem hiding this comment.
We have a newer version of this image hosted in quay.io. Can you update this to quay.io/ibmgaragecloud/ibmcloud-dev:v2.0.4?
| metadata: | ||
| name: ibm-codeengine-deploy | ||
| spec: | ||
| params: |
There was a problem hiding this comment.
All the values except for the image url are provided via the codeengine-access secret and that limits the usability of the task. (I.e. only one app can be deployed per CI namespace.) At the very least, the app name should be a required parameter like the image. Add optional parameters for the other values to allow any of the defaults to be overridden for a particular application. This can be done by defining the parameter with a default value of "", testing the parameter value in the task, and using the default value if one is not provided.
tasks/12-ibm-codeengine-deploy.yaml
Outdated
| - name: CE_DEPLOY | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: codeengine-access |
There was a problem hiding this comment.
This tasks expects a secret named codeengine-access to exist with a particular structure. If the secret exists but it is missing some of the fields it appears this task will fail (e.g. if CE_DEPLOY is set to true but CE_PROJECT_NAME is missing then ibmcloud ce project select -n ${CE_PROJECT_NAME} will fail).
Please provide a file named 12-ibm-codeengine-deploy.md in the tasks/ folder with information about the structure of the secret and instructions on how to create it. If necessary, you can add a shell script in the bin/ folder to help with the process. (I know this is something new but we will be doing the same for the other tasks as well.)
|
Addressed the Review Comments, by changing the input parameter for the task from the CI Stages rather than from Secrets as per Comments. Added .md file for the task |
Added Tekton Task to deploy application to the Code Engine. This to be reviewed and verified, before merging the code