-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add posterior values to output of get_tidy_oxcalresult(). Fixes #32 #33
Conversation
Thank you very much, most appreciated! That travis fails is kind of strange for me... But is also the case in master. I might have to fix that in master, and than you can probably base your pull request on the fixed master again? |
I noticed after making the pull request that |
It is failing now due to system requirements. I try to force travis to a newer ubuntu version, than it will hopefully run. Somewhen during the day... Now I have to teach students for 2 h |
It turns out that the newer version of Oxcal is compiled with glibc 2.29, that is not available for the bionic ubuntu that seem to be the last version travis ships with R language. Since it is cross compilation, I have to 'deliver' that environment. I am on it. |
Hi @MartinHinz. I looked into this a bit since it's also causing stratigraphr to fail on Travis, and I think the problem is that v2.29 isn't available on any version of Ubuntu (https://pkgs.org/download/libc6). This honestly seems like more of a problem with OxCal/Ubuntu, than your package :) I got around it by switching from Travis to GitHub Actions, as recommended here: https://www.tidyverse.org/blog/2020/04/usethis-1-6-0/ |
Thank you so much! As I was expecting it. I just added a branch 'github_action' testing this, and if successful, I will merge this with master switching the testing environment. Keep you posted! |
I just switched in master to github actions, thank you very much for suggesting this. Would you like to rebase your PR on the new master? It is not strictly necessary, but it would probably more clean to go this way? |
Sure, done. |
Thanks alot! Merged. |
Adds getter functions for
posterior_sigma_range
andposterior_probabilities
elements of anoxcAARCalibratedDates
oroxcAARCalibratedDatesList
object; adds those toget_tidy_oxcalresult()
; and updates documentation accordingly.