Accidentally turned off all of the tests but one (uber#865)

* accidentally turned off all of the tests but one * add no test.only lint checks, fix lint a couple of places
IThawk · Jul 10, 2018 · 3bb38c9 · 3bb38c9
1 parent 5140500
commit 3bb38c9
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 8 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -12,11 +12,13 @@
     "max-len": [1, 110, 4],
     "max-params": ["error", 6],
     "object-curly-spacing": 0,
-    "babel/object-curly-spacing": 2
+    "babel/object-curly-spacing": 2,
+    "no-only-tests/no-only-tests": 2
   },
   "parser": "babel-eslint",
   "plugins": [
     "react",
-    "babel"
+    "babel",
+    "no-only-tests"
   ]
 }
diff --git a/package.json b/package.json
@@ -68,6 +68,7 @@
     "eslint-config-uber-es2015": "^3.0.1",
     "eslint-config-uber-jsx": "^3.0.1",
     "eslint-plugin-babel": "^4.0.0",
+    "eslint-plugin-no-only-tests": "^2.0.1",
     "eslint-plugin-react": "^6.9.0",
     "jsdom": "^9.9.1",
     "node-sass": "^4.2.0",

diff --git a/showcase/axes/axis-on-0.js b/showcase/axes/axis-on-0.js
@@ -45,12 +45,12 @@ export default function AxisOn0({
       >
       {!verticalTickValues ||
         verticalTickValues.length ?
-        <VerticalGridLines tickValues={verticalTickValues}/> :
-        null}
+          <VerticalGridLines tickValues={verticalTickValues}/> :
+          null}
       {!horizontalTickValues ||
         horizontalTickValues.length ?
-        <HorizontalGridLines tickValues={horizontalTickValues}/> :
-        null}
+          <HorizontalGridLines tickValues={horizontalTickValues}/> :
+          null}
       <XAxis on0={xAxisOn0} />
       <YAxis on0={yAxisOn0} />
       <LineSeries

diff --git a/src/treemap/treemap-dom.js b/src/treemap/treemap-dom.js
@@ -23,7 +23,18 @@ import TreemapLeaf from './treemap-leaf';
 
 class TreemapDOM extends React.Component {
   render() {
-    const {animation, className, height, hideRootNode, getLabel, mode, nodes, width, scales, style} = this.props;
+    const {
+      animation,
+      className,
+      height,
+      hideRootNode,
+      getLabel,
+      mode,
+      nodes,
+      width,
+      scales,
+      style
+    } = this.props;
     const useCirclePacking = mode === 'circlePack';
     return (
       <div

diff --git a/tests/components/radial-tests.js b/tests/components/radial-tests.js
@@ -71,7 +71,7 @@ test('RadialChart: Showcase Example - Custom radius example', t => {
   t.end();
 });
 
-test.only('RadialChart: Showcase Example - Gradient Pie Example', t => {
+test('RadialChart: Showcase Example - Gradient Pie Example', t => {
   const $ = mount(<GradientPie />);
   // multiplied by two to account for the shadow listeners
   t.equal($.find('.rv-radial-chart__series--pie__slice').length, 3, 'should find the same number of slices as data entries');

diff --git a/yarn.lock b/yarn.lock
@@ -2008,6 +2008,10 @@ eslint-plugin-babel@^4.0.0:
   version "4.1.1"
   resolved "https://registry.yarnpkg.com/eslint-plugin-babel/-/eslint-plugin-babel-4.1.1.tgz#ef285c87039b67beb3bbd227f5b0eed4fb376b87"
 
+eslint-plugin-no-only-tests@^2.0.1:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-no-only-tests/-/eslint-plugin-no-only-tests-2.0.1.tgz#c7bfa82a46be791f9625d720e990632b5dec3c7d"
+
 eslint-plugin-react@^6.7.1, eslint-plugin-react@^6.9.0:
   version "6.10.3"
   resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-6.10.3.tgz#c5435beb06774e12c7db2f6abaddcbf900cd3f78"