-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feature/285/customgallery #368
base: main
Are you sure you want to change the base?
Conversation
I have now implemented the core functionality of custom albums. They are based on the original albums, and not every feature works. (Eg. pinning, album previews) Besides a code-review, there is also a bit of cleanup todo, especially for the strings, since i changed albums to folders. There are probably quite a few missing. My reasoning for this is that it makes more sense, since it actually behaves exactly like the folders in a files app. Also, having three different "album" types might be confusing (Folders, custom albums, dynamic albums) |
I'll review this weekend and do the changes accordingly. Thanks |
Opening media inside the custom albums also don't work |
Oh yeah, i can see that. I'll take a look later! |
Hm, i only used the TimelineScreen like the album does. I cant see whats wrong, sorry |
7d4d8b0
to
c8513ae
Compare
This implements #285