Skip to content

Commit

Permalink
Add GS_BINARY to settings to avoid harcoded call of "gs"
Browse files Browse the repository at this point in the history
  • Loading branch information
JensPfeifle committed Mar 3, 2019
1 parent cbf008f commit ea282c2
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
3 changes: 3 additions & 0 deletions paperless.conf.example
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ PAPERLESS_EMAIL_SECRET=""
# Convert (part of the ImageMagick suite)
#PAPERLESS_CONVERT_BINARY=/usr/bin/convert

# Ghostscript
#PAPERLESS_GS_BINARY = /usr/bin/gs

# Unpaper
#PAPERLESS_UNPAPER_BINARY=/usr/bin/unpaper

Expand Down
3 changes: 3 additions & 0 deletions src/paperless/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,9 @@ def __get_boolean(key, default="NO"):
CONVERT_MEMORY_LIMIT = os.getenv("PAPERLESS_CONVERT_MEMORY_LIMIT")
CONVERT_DENSITY = os.getenv("PAPERLESS_CONVERT_DENSITY")

# Ghostscript
GS_BINARY = os.getenv("PAPERLESS_GS_BINARY", "gs")

# OptiPNG
OPTIPNG_BINARY = os.getenv("PAPERLESS_OPTIPNG_BINARY", "optipng")

Expand Down
11 changes: 7 additions & 4 deletions src/paperless_tesseract/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class RasterisedDocumentParser(DocumentParser):
"""

CONVERT = settings.CONVERT_BINARY
GHOSTSCRIPT = settings.GS_BINARY
DENSITY = settings.CONVERT_DENSITY if settings.CONVERT_DENSITY else 300
THREADS = int(settings.OCR_THREADS) if settings.OCR_THREADS else None
UNPAPER = settings.UNPAPER_BINARY
Expand All @@ -47,12 +48,14 @@ def get_thumbnail(self):
out_path = os.path.join(self.tempdir, "convert.png")
gs_out_path = os.path.join(self.tempdir, "gs_out.png")

# Run convert to get a decent thumbnail

# Extract the first PDF page as a PNG using Ghostscript
# https://github.com/danielquinn/paperless/issues/447
# call gs first
cmd = ["gs", "-q", "-sDEVICE=pngalpha",
"-o", gs_out_path, self.document_path]
cmd = [self.GHOSTSCRIPT,
"-q",
"-sDEVICE=pngalpha",
"-o", gs_out_path,
self.document_path]
if not subprocess.Popen(cmd).wait() == 0:
raise ParseError("Thumbnail (gs) failed at {}".format(cmd))
# then run convert on the output from gs
Expand Down

0 comments on commit ea282c2

Please sign in to comment.