Merge pull request hyperaudio#152 from hyperaudio/150-fragment-selection

150 fragment selection
IgorTavcar · May 3, 2023 · d27d06c · d27d06c
2 parents aaee07a + 9ac0432
commit d27d06c
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/js/hyperaudio-lite.js b/js/hyperaudio-lite.js
@@ -1,5 +1,5 @@
 /*! (C) The Hyperaudio Project. MIT @license: en.wikipedia.org/wiki/MIT_License. */
-/*! Version 2.1.2 */
+/*! Version 2.1.3 */
 
 'use strict';
 
@@ -330,7 +330,18 @@ class HyperaudioLite {
       selection = document.selection.createRange();
     }
 
-    if (selection.toString() !== '' && selection.focusNode !== null && selection.anchorNode !== null) {
+    // check to see if selection is actually inside the transcript
+    let insideTranscript = false;
+    let parentElement = selection.focusNode;
+    while (parentElement !== null) {
+      if (parentElement.id === this.transcript.id) {
+        insideTranscript = true;
+        break;
+      }
+      parentElement = parentElement.parentElement;
+    }
+
+    if (selection.toString() !== '' && insideTranscript === true && selection.focusNode !== null && selection.anchorNode !== null) {
 
       let fNode = selection.focusNode.parentNode;
       let aNode = selection.anchorNode.parentNode;
@@ -352,7 +363,7 @@ class HyperaudioLite {
       }
 
       // if the selection starts with a space we want the next element
-      if(selection.toString().charAt(0) == " ") {
+      if(selection.toString().charAt(0) == " " && aNode !== null) {
         aNode = aNode.nextElementSibling;
       }