Merge pull request apache#747 from metamx/ingest-segment-npe-fix

fix NPE
Igosuki · Sep 17, 2014 · a4777ed · a4777ed
2 parents a17794a + e6d93a3
commit a4777ed
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/indexing-service/src/main/java/io/druid/indexing/firehose/IngestSegmentFirehoseFactory.java b/indexing-service/src/main/java/io/druid/indexing/firehose/IngestSegmentFirehoseFactory.java
@@ -255,13 +255,18 @@ public Sequence<InputRow> apply(final Cursor cursor)
                       final Map<String, DimensionSelector> dimSelectors = Maps.newHashMap();
                       for (String dim : dims) {
                         final DimensionSelector dimSelector = cursor.makeDimensionSelector(dim);
-                        dimSelectors.put(dim, dimSelector);
+                        // dimSelector is null if the dimension is not present
+                        if (dimSelector != null) {
+                          dimSelectors.put(dim, dimSelector);
+                        }
                       }
 
                       final Map<String, ObjectColumnSelector> metSelectors = Maps.newHashMap();
                       for (String metric : metrics) {
                         final ObjectColumnSelector metricSelector = cursor.makeObjectColumnSelector(metric);
-                        metSelectors.put(metric, metricSelector);
+                        if (metricSelector != null) {
+                          metSelectors.put(metric, metricSelector);
+                        }
                       }
 
                       return Sequences.simple(