Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new dicom store selection workflow #265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

igoroctaviano
Copy link
Collaborator

Copy link

deepsource-io bot commented Feb 13, 2025

Here's the code health analysis summary for commits a377b14..d5686f0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 8 occurences introduced
🎯 10 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@igoroctaviano
Copy link
Collaborator Author

@pedrokohler can you please test this locally?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@pedrokohler
Copy link
Collaborator

image

if the users opens this modal, selects "custom" and then cancels without inserting any url, then slim starts operating without a server url. I think this only should be persisted if the users clicks on ok.

@pedrokohler
Copy link
Collaborator

Screenshare.-.2025-02-17.9_59_42.AM.mp4

It looks like we are not able to save the server url when we click on ok. I think this should be the expected behavior.

Copy link
Collaborator

@pedrokohler pedrokohler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not working properly.

@igoroctaviano
Copy link
Collaborator Author

I think it's not working properly.

Can you describe the problem and steps to reproduce?

@pedrokohler
Copy link
Collaborator

I think it's not working properly.

Can you describe the problem and steps to reproduce?

Yes, I have done that in the video and screen shot above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants