Skip to content

extend pre-commit hooks with cython-lint #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2025
Merged

extend pre-commit hooks with cython-lint #2056

merged 3 commits into from
Apr 19, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 17, 2025

In this PR, pre-commit hooks are extended with cython-lint.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Apr 17, 2025
Copy link

github-actions bot commented Apr 17, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_148 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_148 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Apr 17, 2025

Coverage Status

coverage: 86.41% (+0.001%) from 86.409%
when pulling f63bdbb on cython-lint
into f57963e on master.

@vtavana vtavana marked this pull request as ready for review April 17, 2025 22:11
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_149 ran successfully.
Passed: 1108
Failed: 4
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana for going to the effort of adding this

@vtavana vtavana merged commit 3e74087 into master Apr 19, 2025
71 checks passed
@vtavana vtavana deleted the cython-lint branch April 19, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants