Skip to content

[MAINT] Install intel-opencl-rt in chron job #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[MAINT] Install intel-opencl-rt in chron job #2066

merged 1 commit into from
Apr 29, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 29, 2025 •
edited
Loading

This is a work-around for conda install dpctl from dppy/label/dev not installing intel-opencl-rt on Windows

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_164 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@antonwolfy
Copy link
Collaborator

The job seems passing now:
https://github.com/IntelPython/dpctl/actions/runs/14737171870

@ndgrigorian ndgrigorian marked this pull request as ready for review April 29, 2025 17:38
antonwolfy
antonwolfy approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian
The CI failures seem unrelating.

@ndgrigorian ndgrigorian merged commit 0e0f11d into master Apr 29, 2025
82 of 88 checks passed
@ndgrigorian ndgrigorian deleted the fix-chron-job branch April 29, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndgrigorian @antonwolfy