Fix for gh-2121 #2122
Open
Fix for gh-2121 #2122
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2122/index.html |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_58 ran successfully. |
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
reviewed
Jul 10, 2025
| @@ -739,6 +739,9 @@ def astype( | |||
| order=copy_order, | |||
| buffer_ctor_kwargs={"queue": usm_ary.sycl_queue}, | |||
| ) | |||
| # see #2121 | |||
| if ary_dtype == dpt.bool: | |||
| usm_ary = dpt.not_equal(usm_ary, 0, order=order) | |||
There was a problem hiding this comment.
The issue is resolved. Thank you @ndgrigorian!
The only question is about order keyword, why do we pass it as order=order and would it be more efficient to use order=copy_order instead to be aligned with order of R array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix for gh-2121, which is caused by underlying memory of a boolean array not necessarily representing only 0s and 1s, in particular when it is a view from a non-boolean array
This PR adds a path to astype that guarantees
astype(a, "?")will give an output array of only 0 and 1