Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy Support #572

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

fidgetlol
Copy link

The project doesn't reveal the requests arguments needed to support proxies.
I added optional arguments to passthrough to requests.

Copy link
Collaborator

@cmlh cmlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert except requests.exceptions.SSLError for verify=True

@cmlh cmlh self-assigned this Jan 16, 2025
@cmlh cmlh added enhancement New feature or request Python labels Jan 16, 2025
@fidgetlol
Copy link
Author

Insert except requests.exceptions.SSLError for verify=True

I don't understand. Do you want me to put all the web requests in a try: ... except requests.exceptions.SSLError: ?

@cmlh
Copy link
Collaborator

cmlh commented Jan 17, 2025

@fidgetlol wrote

I don't understand. Do you want me to put all the web requests in a try: ... except requests.exceptions.SSLError: ?

Is this exception thrown for you when verify=None is omitted? If so I can insert a command line argument similar to curl's --proxy-insecure within the intelx.py Python script?

@fidgetlol
Copy link
Author

Is this exception thrown for you when verify=None is omitted? If so I can insert a command line argument similar to curl's --proxy-insecure within the intelx.py Python script?

ah, no exception is thrown when I replaced verify=None with verify=True. My use case requires a CA_BUNDLE to be passed, and testing without a proxy worked either way.

@cmlh
Copy link
Collaborator

cmlh commented Jan 17, 2025

@fidgetlol wrote

ah, no exception is thrown when I replaced verify=None with verify=True. My use case requires a CA_BUNDLE to be passed, and testing without a proxy worked either way.

OK, the default will be set to verify=True but can be changed by the end user.

Do you want to contribute (in order) for the next minor v0.7 release:

@fidgetlol
Copy link
Author

verify is done and I added a --proxy-insecure flag to the script.

I'm still not sure how you want an SSLError handled.

@cmlh
Copy link
Collaborator

cmlh commented Jan 22, 2025

@fidgetlol wrote:

I'm still not sure how you want an SSLError handled.

I can insert requests.exceptions.SSLError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants